dianfu commented on a change in pull request #11901:
URL: https://github.com/apache/flink/pull/11901#discussion_r415228631



##########
File path: 
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/ExecutionContextTest.java
##########
@@ -198,6 +201,22 @@ public void testFunctions() throws Exception {
                assertArrayEquals(expected, actual);
        }
 
+       @Test
+       public void testPythonFunction() throws Exception {

Review comment:
       The test case could be improved as following:
   ```
   PowerMockito.stub(PowerMockito.method(PythonFunctionFactory.class, 
"getPythonFunctionFactory", ReadableConfig.class)).toReturn(
                        (PythonFunctionFactory) (moduleName, objectName) -> new 
PythonScalarFunction(null, null, null, null, null, false, null));
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to