JingsongLi commented on a change in pull request #11910:
URL: https://github.com/apache/flink/pull/11910#discussion_r415261016
##########
File path: flink-connectors/flink-connector-cassandra/pom.xml
##########
@@ -172,7 +172,7 @@ under the License.
<!-- A planner dependency won't be necessary once FLIP-32 has
been completed. -->
<dependency>
<groupId>org.apache.flink</groupId>
-
<artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+
<artifactId>flink-table-planner-blink_${scala.binary.version}</artifactId>
Review comment:
Why just change cassandra?
Maybe scope to test and remove above comments?
##########
File path:
flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/scala/StreamSQLExample.scala
##########
@@ -49,12 +49,16 @@ object StreamSQLExample {
val env = StreamExecutionEnvironment.getExecutionEnvironment
val tEnv = if (planner == "blink") { // use blink planner in streaming
mode
Review comment:
Minor: `EnvironmentSettings.Builder settingsBuilder =
EnvironmentSettings.newInstance().inStreamingMode();` to reuse
`StreamTableEnvironment.create` code.
`StreamSQLExample.java` too.
##########
File path: flink-python/pyflink/table/tests/test_table_environment_api.py
##########
@@ -275,16 +275,16 @@ def
test_create_table_environment_with_blink_planner(self):
self.assertEqual(
planner.getClass().getName(),
- "org.apache.flink.table.planner.StreamPlanner")
+ "org.apache.flink.table.planner.delegation.StreamPlanner")
t_env = StreamTableEnvironment.create(
-
environment_settings=EnvironmentSettings.new_instance().use_blink_planner().build())
+
environment_settings=EnvironmentSettings.new_instance().use_old_planner().build())
Review comment:
Why change to old? test name is
`test_create_table_environment_with_blink_planner`? maybe should change method
name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
