[ 
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093084#comment-17093084
 ] 

Dawid Wysakowicz commented on FLINK-17356:
------------------------------------------

A {{UNIQUE KEY}} is commonly used term for a {{UNIQUE}} constraint. Both 
{{PRIMARY KEY}} and {UNIQUE}} uniquely identify a row in a table and thus can 
be called a "key".

If I understand it correctly the question is about changing a name of an enum 
that is actually more of an internal flag not exposed to users. I don't have a 
strong opinion on keeping the current name, so if you both find it misleading I 
am fine with it. I don't see any benefit of it though.

https://docs.oracle.com/database/121/SUTIL/GUID-AFEA0C77-BA3D-4E2D-B4C2-76468FC54AAD.htm#SUTIL1355
https://docs.microsoft.com/en-us/sql/relational-databases/tables/create-unique-constraints?view=sql-server-ver15

> Properly set constraints (PK and UNIQUE)
> ----------------------------------------
>
>                 Key: FLINK-17356
>                 URL: https://issues.apache.org/jira/browse/FLINK-17356
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Connectors / JDBC, Table SQL / Ecosystem
>            Reporter: Flavio Pompermaier
>            Priority: Major
>              Labels: pull-request-available
>
> At the moment the PostgresCatalog does not create field constraints (at the 
> moment there's only UNIQUE and  PRIMARY_KEY in the TableSchema..could it 
> worth to add also NOT_NULL?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to