[ 
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093159#comment-17093159
 ] 

Dawid Wysakowicz commented on FLINK-17356:
------------------------------------------

I really don't have a strong opinion on it. I'll leave the decision up to the 
reviewer. ;)

One additional thing to consider. I think currently the runtime does not use 
the information about {{UNIQUE}} keys (correct me if I am wrong here). I would 
suggest reconsidering if it is worth propagating the unique constraint right 
now if it is not used by the runtime. It might confuse users. Again I am fine 
if you decide to do it already.

> Properly set constraints (PK and UNIQUE)
> ----------------------------------------
>
>                 Key: FLINK-17356
>                 URL: https://issues.apache.org/jira/browse/FLINK-17356
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Connectors / JDBC, Table SQL / Ecosystem
>            Reporter: Flavio Pompermaier
>            Priority: Major
>              Labels: pull-request-available
>
> At the moment the PostgresCatalog does not create field constraints (at the 
> moment there's only UNIQUE and  PRIMARY_KEY in the TableSchema..could it 
> worth to add also NOT_NULL?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to