tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415808063
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1012,10 +1016,34 @@ public void disconnectResourceManager(Exception cause) {
}
}
+ @Override
+ public CompletableFuture<ThreadDumpInfo> requestThreadDump(Time
timeout) {
+ final Collection<ThreadInfo> threadDump =
JvmUtils.createThreadDump();
+
+ final Collection<ThreadDumpInfo.ThreadInfo> threadInfos =
threadDump.stream()
+ .map(threadInfo ->
ThreadDumpInfo.ThreadInfo.create(threadInfo.getThreadName(),
threadInfo.toString()))
Review comment:
As soon as the RestResponse and the internal cluster message differ I
will introduce a separate the classes. As long as they are identical I think it
is fine to use the same class here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
