[
https://issues.apache.org/jira/browse/FLINK-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093899#comment-15093899
]
ASF GitHub Bot commented on FLINK-3140:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1465#issuecomment-170916212
Hi Timo, the PR looks good except for the `extractKeys` and
`getFlatComparator` methods. I think it is possible to support composite type
wrapping with the `NullAwareComparator` but we need to take care of composite
types in `extractKeys` and `getFlatComparators`.
> NULL value data layout in Row Serializer/Comparator
> ---------------------------------------------------
>
> Key: FLINK-3140
> URL: https://issues.apache.org/jira/browse/FLINK-3140
> Project: Flink
> Issue Type: Sub-task
> Components: Table API
> Reporter: Chengxiang Li
> Assignee: Timo Walther
>
> To store/materialize NULL value in Row objects, we should need new Row
> Serializer/Comparator which is aware of NULL value fields.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
