[
https://issues.apache.org/jira/browse/FLINK-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093918#comment-15093918
]
ASF GitHub Bot commented on FLINK-3140:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1465#issuecomment-170921788
The `NullAwareComparator` knows about the order of its wrapped comparator.
So we can implement the `getFlatComparators()` method of `NullAwareComparator`,
call `getFlatComparators()` on the wrapped comparator and wrap each returned
comparator again in a `NullAwareComparator` with the same order as the wrapping
one. I think that should work, but maybe I am overlooking something here...
IMO, the problem with `isAscending()` is that it is only implemented for
BasicTypes (Int, String, etc.) but not for other atomic types such as generic
or writable types.
> NULL value data layout in Row Serializer/Comparator
> ---------------------------------------------------
>
> Key: FLINK-3140
> URL: https://issues.apache.org/jira/browse/FLINK-3140
> Project: Flink
> Issue Type: Sub-task
> Components: Table API
> Reporter: Chengxiang Li
> Assignee: Timo Walther
>
> To store/materialize NULL value in Row objects, we should need new Row
> Serializer/Comparator which is aware of NULL value fields.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
