wangyang0918 commented on a change in pull request #11903:
URL: https://github.com/apache/flink/pull/11903#discussion_r417916795
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
##########
@@ -302,8 +302,8 @@ public boolean isActive(CommandLine commandLine) {
final boolean yarnJobManager = ID.equals(jobManagerOption);
final boolean hasYarnAppId =
commandLine.hasOption(applicationId.getOpt())
||
configuration.getOptional(YarnConfigOptions.APPLICATION_ID).isPresent();
- final boolean hasYarnExecutor =
YarnSessionClusterExecutor.NAME.equals(configuration.get(DeploymentOptions.TARGET))
- ||
YarnJobClusterExecutor.NAME.equals(configuration.get(DeploymentOptions.TARGET));
+ final boolean hasYarnExecutor =
YarnSessionClusterExecutor.NAME.equalsIgnoreCase(configuration.get(DeploymentOptions.TARGET))
+ ||
YarnJobClusterExecutor.NAME.equalsIgnoreCase(configuration.get(DeploymentOptions.TARGET));
Review comment:
Since the `--target` does not active this command line, we need to move
`setLogConfigFileInConfig` to `YarnClusterDescriptor` or somewhere. So that the
`ExecutorCLI` could also correctly set the log4j/logback configuration.
In the current implementation, the jobmanager.log could not be accessed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
