zentol commented on a change in pull request #18: URL: https://github.com/apache/flink-docker/pull/18#discussion_r421326344
########## File path: README.md ########## @@ -24,6 +24,17 @@ Flink Docker image lifecycle https://github.com/docker-library/official-images/blob/master/library/flink). +Development workflow +---------------------------- + +The `master` branch of this repository serves as a pure publishing area for releases. + +Development happens on the various `dev-X` branches. + +Pull requests for a specific version should be opened against the respective `dev-<version>` branch. +Pull requests for all versions, or for the next major Flink release, should be opened against the `dev-master` branch. Review comment: I suppose what currently will happen is that the dev-1.x branches work against release Flink versionsd (so, docker-1.x-snapshot tests against Flink 1.x), while the Flink release-1.x branches work again released docker images (so, flink-1.x-snapshot tests against docker 1.x). This is fine I think; the above should give us enough guarantees that we don't need to explicitly test for snapshot <-> snapshot. ########## File path: README.md ########## @@ -24,6 +24,17 @@ Flink Docker image lifecycle https://github.com/docker-library/official-images/blob/master/library/flink). +Development workflow +---------------------------- + +The `master` branch of this repository serves as a pure publishing area for releases. + +Development happens on the various `dev-X` branches. + +Pull requests for a specific version should be opened against the respective `dev-<version>` branch. +Pull requests for all versions, or for the next major Flink release, should be opened against the `dev-master` branch. Review comment: I suppose what currently will happen is that the dev-1.x branches work against release Flink versions (so, docker-1.x-snapshot tests against Flink 1.x), while the Flink release-1.x branches work again released docker images (so, flink-1.x-snapshot tests against docker 1.x). This is fine I think; the above should give us enough guarantees that we don't need to explicitly test for snapshot <-> snapshot. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
