wangyang0918 commented on a change in pull request #12003:
URL: https://github.com/apache/flink/pull/12003#discussion_r421924703



##########
File path: 
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesUtils.java
##########
@@ -179,6 +187,22 @@ public static String getCommonStartCommand(
                return BootstrapTools.getStartCommand(commandTemplate, 
startCommandValues);
        }
 
+       public static File checkJarFileForApplicationMode(Configuration 
configuration) {

Review comment:
       Nice suggestion. I will create a new class `ApplicationUtils` and move 
`resolveURI` and `checkLocalJarFilesForApplicationMode` in since they could be 
used by other deployment(e.g. Yarn application).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to