wangyang0918 commented on pull request #12003:
URL: https://github.com/apache/flink/pull/12003#issuecomment-625642618
@kl0u I am afraid that we could reuse`jarsOnClasspath` because it means the
jar is located in the classpath. However, for K8s application, user could
specify an arbitrary jar anywhere in the image. Maybe in the future we could
remove `jarsOnClassPath` since we do not call `setJarsOnClassPath` in the
production code.
For `YarnApplicationClusterEntryPoint`,
`KubernetesApplicationClusterEntrypoint `, `StandaloneJobClusterEntrypoint`,
they have some similar logics about `getPackagedProgram` and
`getPackagedProgramRetriever`. I agree with you that we could deduplicate them
in the follow-ups.
@zhengcanbin I also find this issue when i test the K8s application mode.
After add i small sleep(or any other command) via
`kubernetes.container-start-command-template`. It could work. I think it
because the `PID` 1 is not the java process and will not make response to the
`SIGTERM`.
We need to create a new follow-up ticket for this issue and find a proper
solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
