Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1462#discussion_r49789099
  
    --- Diff: 
flink-scala/src/main/scala/org/apache/flink/api/scala/utils/package.scala ---
    @@ -103,6 +105,25 @@ package object utils {
           : DataSet[T] = {
           wrap(jutils.sampleWithSize(self.javaSet, withReplacement, 
numSamples, seed))
         }
    +
    +    // 
--------------------------------------------------------------------------------------------
    +    //  Checksum
    +    // 
--------------------------------------------------------------------------------------------
    +
    +    /**
    +      * Convenience method to get the count (number of elements) of a 
DataSet
    +      * as well as the checksum (sum over element hashes).
    +      *
    +      * @return A ChecksumHashCode with the count and checksum of elements 
in the data set.
    +      *
    +      * @see [[org.apache.flink.api.java.Utils.ChecksumHashCodeHelper]]
    +      */
    +    def checksumHashCode: ChecksumHashCode = {
    --- End diff --
    
    Would be good to give this method parenthesis. It triggers distributed 
execution, so is not quite side-effect free.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to