Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1462#issuecomment-171789574
Looks good. One comment about parenthesis on the Scala methods, otherwise
good.
To safe testing uild time, we could add the tests of this to some existing
test class (like MiscellaneousITCase). Messes up class separation a bit, but
saves a lot of build time in the long run, because the main test time goes into
the starting to the test mini cluster (which is once per class).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
