pnowojski commented on a change in pull request #12016:
URL: https://github.com/apache/flink/pull/12016#discussion_r422832679
##########
File path: flink-end-to-end-tests/test-scripts/test_quickstarts.sh
##########
@@ -68,6 +68,13 @@ sed -i -e ''$(($position + 1))'i\
sed -i -e
"s/org.apache.flink.quickstart.StreamingJob/org.apache.flink.quickstart.$TEST_CLASS_NAME/"
pom.xml
+if [[ $PROFILE == *"scala-2.12"* ]]; then
+ echo "Changing scala version"
+ sed -i -e
"s/scala.binary.version>2.11<\/scala.binary/scala.binary.version>2.12<\/scala.binary/"
pom.xml
+ # for flink-quickstart-scala, also change scala version
+ sed -i -e
"s/scala.version>2.11.12<\/scala.ver/scala.version>2.12.7<\/scala.ver/" pom.xml
+fi
+
Review comment:
maybe add bashy equivalent of
```
else if profile == 2.11 do nothing
else throw new UnsupportedOperationException()
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
