zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422972620
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -428,6 +423,23 @@ public void notifyBufferDestroyed() {
// Nothing to do actually.
}
+ @Override
+ public void onCheckpointBarrier(CheckpointBarrier barrier) {
Review comment:
Considering the race condition between this operation and canceler task,
it might involve in potential conflicts and deadlock case if
`removeBufferListener` and adjust `isWaitingForFloatingBuffers` here. Let me
think whether we can lazy remove the listener and adjust
`isWaitingForFloatingBuffers` by reusing the existing process
`RemoteInputChannel#notifyBufferAvailable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
