zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422868983
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -94,13 +99,27 @@ public void requestSubpartitionView(
}
@Override
- public void addCredit(int creditDeltas) {
+ public boolean addCredit(int creditDeltas) {
numCreditsAvailable += creditDeltas;
+ return shouldAnnounceBacklog();
Review comment:
why we need to trigger announce backlog while adding credit?
I assume since the added `creditDeltas` is always more than zero, then we
have the chance to announce the backlog later via sending `BufferResponse`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
