gaoyunhaii commented on a change in pull request #12134: URL: https://github.com/apache/flink/pull/12134#discussion_r425487440
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/write/HadoopPathBasedBulkWriterFactory.java ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connectors.hive.write; + +import org.apache.flink.api.common.serialization.PathBasedBulkWriter; + +import org.apache.hadoop.fs.Path; + +/** + * Factory for path-based bulk file writer that writes to the specific hadoop path. + */ +public abstract class HadoopPathBasedBulkWriterFactory<T> implements PathBasedBulkWriter.Factory<T> { + + @Override + public final PathBasedBulkWriter<T> create( + org.apache.flink.core.fs.Path targetPath, + org.apache.flink.core.fs.Path inProgressPath) { + + return create( + new Path(targetPath.toUri()), + new Path(inProgressPath.toUri())); + } + + /** + * Creates a path-based writer that writes to the <tt>inProgressPath</tt> first + * and commits to <tt>targetPath</tt> finally. + * + * @param targetPath The final hadoop path to commit to. + * @param inProgressPath The intermediate hadop path to write to before committing. + * @return The created writer. + */ + public abstract PathBasedBulkWriter<T> create(Path targetPath, Path inProgressPath); Review comment: Changed accordingly and also other related occurrence of `Path`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
