gaoyunhaii commented on a change in pull request #12134:
URL: https://github.com/apache/flink/pull/12134#discussion_r425487823
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -128,24 +128,12 @@
private transient ListState<Long> maxPartCountersState;
/**
- * Creates a new {@code StreamingFileSink} that writes files in
row-based format to the given base directory.
+ * Creates a new {@code StreamingFileSink} that writes files to the
given base directory
Review comment:
I think it should not affect compatibility since it is only called from
`BucketsBuilder`. Besides, it should be only extends its ability to accept more
types of `BucketsBuilder`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
