Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1500#discussion_r49995630
  
    --- Diff: flink-staging/flink-scala-shell/start-script/start-scala-shell.sh 
---
    @@ -75,11 +75,20 @@ do
         fi
     done
     
    +log_setting=""
    +
    +if [[ $1 = "yarn" ]]
    +then
    
+FLINK_CLASSPATH=$FLINK_CLASSPATH:$HADOOP_CLASSPATH:$HADOOP_CONF_DIR:$YARN_CONF_DIR
    +log=$FLINK_LOG_DIR/flink-$FLINK_IDENT_STRING-yarn-session-$HOSTNAME.log
    --- End diff --
    
    Why calling the log file like it is called when you start a dedicated yarn 
session via `yarn-session.sh`? Isn't this a bit confusing? Why not calling it 
`flink-$FLINK_IDENT_STRING-scala-shell-yarn-$HOSTNAME.log?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to