Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1500#discussion_r51705046
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/FlinkYarnSessionCli.java ---
    @@ -417,13 +417,9 @@ public int run(String[] args) {
                        String jobManagerAddress = 
yarnCluster.getJobManagerAddress().getAddress().getHostAddress() + ":" + 
yarnCluster.getJobManagerAddress().getPort();
                        System.out.println("Flink JobManager is now running on 
" + jobManagerAddress);
                        System.out.println("JobManager Web Interface: " + 
yarnCluster.getWebInterfaceURL());
    -                   // file that we write into the conf/ dir containing the 
jobManager address and the dop.
    -
    -                   String defaultPropertiesFileLocation = 
System.getProperty("java.io.tmpdir");
    -                   String currentUser = System.getProperty("user.name");
    -                   String propertiesFileLocation = 
yarnCluster.getFlinkConfiguration().getString(ConfigConstants.YARN_PROPERTIES_FILE_LOCATION,
 defaultPropertiesFileLocation);
     
    -                   File yarnPropertiesFile = new 
File(propertiesFileLocation + File.separator + CliFrontend.YARN_PROPERTIES_FILE 
+ currentUser);
    +                   // file that we write into the conf/ dir containing the 
jobManager address and the dop.
    +                   File yarnPropertiesFile = new 
File(getYarnPropertiesLocation(yarnCluster.getFlinkConfiguration()));
    --- End diff --
    
    The yarnPropertiesFile path construction is also done in `CliFrontend:173`. 
This should also be changed to use the new `getYarnPropertiesLocation` method. 
Maybe moving this method to `CliFrontend` makes sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to