igalshilman commented on a change in pull request #110:
URL: https://github.com/apache/flink-statefun/pull/110#discussion_r425772632
##########
File path:
statefun-flink/statefun-flink-core/src/test/java/org/apache/flink/statefun/flink/core/jsonmodule/JsonModuleTest.java
##########
@@ -95,6 +96,7 @@ public void testEgresses() {
private static StatefulFunctionModule fromPath(String path) {
URL moduleUrl = JsonModuleTest.class.getClassLoader().getResource(path);
+ assertThat(moduleUrl, not(nullValue()));
Review comment:
That’s fine, don’t worry about it.
We don’t necessarily squash, a single PR can produce multiple commits and
they will be merged as is.
That’s why we try to separate the changes, i.e: did the thing, added test,
refactored the test etc’
But don’t worry about it now, this is for your next PR ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
