zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r425833911
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name
${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
Review comment:
maybe, I'm not so sure about it. On the one hand there are some
environmental dependencies (see above) and you would need to harden it way more
to ensure cleanup of resources (which I'd prefer not to do atm).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
