zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r425837430
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name
${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
+ pushd ${FLINK_DIR}/..
+ tar -czf "${TEST_DATA_DIR}/flink.tgz" flink-*
+ popd
+ pushd ${TEST_DATA_DIR}
+ python -m SimpleHTTPServer 9999 &
Review comment:
Given that we are primarily interested in the running on CI I'm fine
with the current state.
For the general case it can blow up in any case since you can't guarantee
python (2 or 3) to exist at all; the only safe solution being a pure bash/java
version, bash naturally not being realistic option and Java not really being
worth the additional effort, and it would also make it way harder to offer a
script in that case.
Originally I wanted to serve things via netcat but it didn't quite work.
Dockerizing this one thing seems a bit overkill to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
