godfreyhe opened a new pull request #12188:
URL: https://github.com/apache/flink/pull/12188
## What is the purpose of the change
*currently, all statements in sql client are parsed via regex matching,
which has many limitations, such as it can't handle comments. To avoid that
limitations, we should try best to use sql parser to parse a statement. There
are many statement can't be handle by sql parser, such as: set, reset. So they
are still handle through regex matching.
statements handled through regex matching:
quit, exit, clear, help, desc, explain, set, reset source, show modules
statements handled through sql parser:
show catalogs, show databases, show tables, show functions, use catalog,
use, describe, explain plan for, select, insert, DDLs*
## Brief change log
- *SqlCommandParser parses a statement via sql parse, and then via regex
matching*
## Verifying this change
This change added tests and can be verified as follows:
- *extended SqlCommandParserTest to verify all cases*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
