godfreyhe commented on a change in pull request #12188:
URL: https://github.com/apache/flink/pull/12188#discussion_r426140427
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/SqlCommandParser.java
##########
@@ -207,6 +301,10 @@ public String toString() {
public boolean hasOperands() {
return operandConverter != NO_OPERANDS;
}
Review comment:
`NO_OPERANDS ` is internal variable and NO_OPERANDS is a static final
instance. we can use `!=` to do compare
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
