curcur opened a new pull request #12269:
URL: https://github.com/apache/flink/pull/12269


   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Before this PR, `CHECKPOINT_EXPIRED` is not counted in 
`continuousFailureCounter`. Hence,
   if the failure of checkpointing is detected after checkpoint times out, the 
failure get ignored since
   the `PendingCheckpoint` has already been discarded, leading the job unable 
to restart automatically in theory
   unless something else fails.
   
   This PR counts `CHECKPOINT_EXPIRED` in `continuousFailureCounter`.
   
   
   ## Brief change log
   
   - `CHECKPOINT_EXPIRED` is counted in 
`CheckpointFailureManager#continuousFailureCounter`.
   
   ## Verifying this change
   unit tests 
   
`CheckpointCoordinatorTest#testExpiredCheckpointExceedsTolerableFailureNumber`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: Checkpointing
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented?  not applicable 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to