[GitHub] [flink] JingsongLi commented on a change in pull request #12260: [FLINK-17189][table-planner] Table with proctime attribute cannot be read from Hive catalog

[GitBox]

JingsongLi commented on a change in pull request #12260:
URL: https://github.com/apache/flink/pull/12260#discussion_r428630159



##########
File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/sources/TableSourceUtil.scala
##########
@@ -238,6 +250,14 @@ object TableSourceUtil {
     }
   }
 
+  private def containsTimeAttribute(tableSchema: TableSchema): Boolean = {
+    tableSchema.getWatermarkSpecs.nonEmpty || 
tableSchema.getTableColumns.exists(isProctime)
+  }
+
+  private def isProctime(column: TableColumn): Boolean = {
+    toScala(column.getExpr).exists(_.equalsIgnoreCase("proctime()"))
+  }

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org