klion26 commented on a change in pull request #12282:
URL: https://github.com/apache/flink/pull/12282#discussion_r429638795
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendLoadingTest.java
##########
@@ -227,7 +228,7 @@ public void testLoadFileSystemStateBackend() throws
Exception {
final String savepointDir = new
Path(tmp.newFolder().toURI()).toString();
final Path expectedCheckpointsPath = new Path(checkpointDir);
final Path expectedSavepointsPath = new Path(savepointDir);
- final int threshold = 1000000;
+ final MemorySize threshold = MemorySize.parse("900kb");
Review comment:
Do you think we need to add a test case to verify the default value of
`state.backend.fs.memory-threshold`(do not set this key, and verify the result
of `getMinFileSizeThreshold()` is the expected value)
##########
File path: docs/_includes/generated/checkpointing_configuration.html
##########
@@ -22,9 +22,9 @@
</tr>
<tr>
<td><h5>state.backend.fs.memory-threshold</h5></td>
- <td style="word-wrap: break-word;">1024</td>
- <td>Integer</td>
- <td>The minimum size of state data files. All state chunks smaller
than that are stored inline in the root checkpoint metadata file.</td>
+ <td style="word-wrap: break-word;">20 kb</td>
+ <td>MemorySize</td>
+ <td>The minimum size of state data files. All state chunks smaller
than that are stored inline in the root checkpoint metadata file. The max
memory threshold for this configuration is 1MB.</td>
Review comment:
Good to add the upper limit here :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
