wuchong commented on a change in pull request #12289:
URL: https://github.com/apache/flink/pull/12289#discussion_r429740951
##########
File path:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/util/HBaseTypeUtils.java
##########
@@ -81,13 +81,16 @@ public static Object deserializeToObject(byte[] value, int
typeIdx, Charset stri
* Serialize the Java Object to byte array with the given type.
*/
public static byte[] serializeFromObject(Object value, int typeIdx,
Charset stringCharset) {
+ if (value == null){
+ return EMPTY_BYTES;
Review comment:
The rowkey from HBase will never be null or emtpy bytes, but the
qualifiers will be an empty bytes because that's what we write in the
`serializeFromObject`.
##########
File path:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/util/HBaseTypeUtils.java
##########
@@ -81,13 +81,16 @@ public static Object deserializeToObject(byte[] value, int
typeIdx, Charset stri
* Serialize the Java Object to byte array with the given type.
*/
public static byte[] serializeFromObject(Object value, int typeIdx,
Charset stringCharset) {
+ if (value == null){
+ return EMPTY_BYTES;
Review comment:
The rowkey from HBase will never be null or emtpy bytes, but the
qualifiers might be an empty bytes because that's what we write in the
`serializeFromObject`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
