azagrebin commented on a change in pull request #11245:
URL: https://github.com/apache/flink/pull/11245#discussion_r430332353
##########
File path: docs/ops/deployment/kubernetes.md
##########
@@ -159,6 +159,8 @@ with the `kubectl` command:
## Appendix
### Common cluster resource definitions
+The Deployment definitions use the pre-built image `flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}`{% else %}latest` (which
contains the latest released Flink built against Scala 2.12){% endif %} which
can be found [on Docker Hub](https://hub.docker.com/_/flink/).
+The image is built from this [Github
repository](https://github.com/apache/flink-docker).
Review comment:
We already have a chapter on this page about the image, I would rather
refer to it: `#flink-docker-image`.
This way we would have to change the image description only in one place.
Also, the information about scala 2.12 for latest can become stale, it would
make sense to just refer to the tags page. We have everywhere Scala 2.11 by
default except docker and might want to make it 2.11 for docker as well later.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java
##########
@@ -103,6 +103,15 @@ public static String getGitCommitTimeString() {
return getVersionsInstance().gitCommitTimeStr;
}
+ /**
+ * Returns the exact name of the Dockerimage for Flink that is needed
to run in.
+ *
+ * @return The "name:tag" of the Flink docker image.
+ */
+ public static String getFlinkDockerImageNameAndTag() {
Review comment:
Why do you think this function belongs to `EnvironmentInformation `?
It looks to me as just a private helper method for `CONTAINER_IMAGE` option
for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
