azagrebin commented on a change in pull request #11245:
URL: https://github.com/apache/flink/pull/11245#discussion_r433713061
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -121,8 +122,11 @@
public static final ConfigOption<String> CONTAINER_IMAGE =
key("kubernetes.container.image")
.stringType()
- .defaultValue("flink:latest")
- .withDescription("Image to use for Flink containers.");
+ .defaultValue("flink:" + EnvironmentInformation.getVersion() +
"-scala_" + EnvironmentInformation.getScalaVersion())
Review comment:
Do you think now we should not put this to a private helper
method/static var?
##########
File path: docs/ops/deployment/kubernetes.md
##########
@@ -262,7 +262,7 @@ spec:
spec:
containers:
- name: jobmanager
- image: flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif %}
+ image: flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest # The
'latest' tag contains the latest released version of Flink for a specific Scala
version which will mismatch with your application over time.{% endif %}
Review comment:
```suggestion
image: flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest # The
'latest' tag contains the latest released version of Flink for a specific Scala
version which can mismatch with the Scala version of your application.{% endif
%}
```
Will the Scala version definitely mismatch?
I am wondering why this comment should be in all places. This is for dev
docs.
Could we not put this comment to that note in the relevant docker/tags
chapter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
