Jiayi-Liao opened a new pull request #12444:
URL: https://github.com/apache/flink/pull/12444


   # What is the purpose of the change
   
   As discussed in 
https://github.com/apache/flink/pull/11176#discussion_r433629963, the default 
value of yarnMinAllocationMB is set to zero, which will crash the job in 
normalization. Here I propose to modify the default value to 
`YarnConfiguration.DEFAULT_RM_SCHEDULER_MINIMUM_ALLOCATION_MB`, which is 
obviously more sensible.
   
   ## Brief change log
   
   * Make the default value to 
YarnConfiguration.DEFAULT_RM_SCHEDULER_MINIMUM_ALLOCATION_MB, not 0
   * Add pre-check for yarnMinAllocationMB, it should be greater than 0.
   
   ## Verifying this change
   
   This should be covered in existing unit tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to