Jiayi-Liao commented on a change in pull request #12444:
URL: https://github.com/apache/flink/pull/12444#discussion_r434277415
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -508,7 +508,9 @@ public void killCluster(ApplicationId applicationId) throws
FlinkException {
throw new YarnDeploymentException("Could not retrieve
information about free cluster resources.", e);
}
- final int yarnMinAllocationMB =
yarnConfiguration.getInt(YarnConfiguration.RM_SCHEDULER_MINIMUM_ALLOCATION_MB,
0);
+ final int yarnMinAllocationMB = yarnConfiguration.getInt(
Review comment:
I put in `validateClusterResources` because I thought it's a part of the
validation, but I'm also okay with your way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]