aljoscha commented on pull request #12412: URL: https://github.com/apache/flink/pull/12412#issuecomment-637589309
@StephanEwen Thanks for the review! about 1) I had a version where `WatermarkStrategy` is an `abstract class`, where the strategy implementations were final static private classes. This doesn't work for an `interface`, so I will move them out. about 2) I will write more class-level documentation and also structure it as you proposed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
