kl0u opened a new pull request #12455:
URL: https://github.com/apache/flink/pull/12455


   ## What is the purpose of the change
   
   This PR fixes the problem that when using the `ExecutorCLI` to access Yarn, 
the configuration directory is not picked up and the log configuration is 
missing.
   
   ## Brief change log
   
   We fix the issue by moving the setting of yarn's 
`APPLICATION_LOG_CONFIG_FILE` to the 
`YarnClusterClientFactory.createClusterDescriptor()`. This change has the 
additional benefit that the `YarnClusterDescriptor` is not bound to the 
implicit contract of discovery of the configuration dir (see 
`CliFrontend.getConfigurationDirectoryFromEnv()`).
    
   ## Verifying this change
   
   This change is already covered by the existing yarn tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to