kl0u commented on a change in pull request #12455:
URL: https://github.com/apache/flink/pull/12455#discussion_r434803907
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/cli/KubernetesSessionCli.java
##########
@@ -68,14 +69,14 @@
private final ExecutorCLI cli;
private final ClusterClientServiceLoader clusterClientServiceLoader;
- public KubernetesSessionCli(Configuration configuration) {
- this(configuration, new DefaultClusterClientServiceLoader());
+ public KubernetesSessionCli(Configuration configuration, String
configDir) {
+ this(configuration, new DefaultClusterClientServiceLoader(),
configDir);
}
- public KubernetesSessionCli(Configuration configuration,
ClusterClientServiceLoader clusterClientServiceLoader) {
+ public KubernetesSessionCli(Configuration configuration,
ClusterClientServiceLoader clusterClientServiceLoader, String configDir) {
this.baseConfiguration = new
UnmodifiableConfiguration(checkNotNull(configuration));
this.clusterClientServiceLoader =
checkNotNull(clusterClientServiceLoader);
- this.cli = new ExecutorCLI(baseConfiguration);
+ this.cli = new ExecutorCLI(baseConfiguration, configDir);
Review comment:
Thanks for the hint @wangyang0918, I was not aware that we use the
discovery in so many places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
