[ 
https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119154#comment-15119154
 ] 

ASF GitHub Bot commented on FLINK-3292:
---------------------------------------

Github user sbcd90 commented on the pull request:

    https://github.com/apache/flink/pull/1551#issuecomment-175592466
  
    Hello zentol,
    
    To answer your initial question,
    
    ```
    is there any way to check which createStatement method is supported? what 
happens if you use the wrong statement?
    ```
    
    I went into the Jdbc driver code & found that both methods are supported, 
however, with the ones defaulted in the code,
    ResultSet.TYPE_SCROLL_INSENSITIVE
    ResultSet.CONCUR_READ_ONLY
    
    I got this error, 
    ```
    java.sql.SQLException: Result set type is TYPE_FORWARD_ONLY
    ```
    
    I think both variants should be supported & it is up to the api user to 
specify which variant they should go for. Hence, this PR. Kindly let me know if 
the changes in code are fine now. 


> Bug in flink-jdbc. Not all JDBC drivers supported
> -------------------------------------------------
>
>                 Key: FLINK-3292
>                 URL: https://issues.apache.org/jira/browse/FLINK-3292
>             Project: Flink
>          Issue Type: Bug
>          Components: other
>    Affects Versions: 1.0.0
>            Reporter: Subhobrata Dey
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> Hello,
> In method open in JDBCInputFormat.java, while using dbConn.createStatement, 
> the resultSetType & resultSetConcurrency are hardcoded. 
> These two fields may vary with different JDBC drivers & hence it fails in a 
> few cases like SAP HANA Jdbc driver. 
> There are two variants of the method dbCon.createStatement, one with 
> parameters & the other without  parameters. Both should be supported. 
> Thanks & regards,
> Subhobrata



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to