[ 
https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119346#comment-15119346
 ] 

ASF GitHub Bot commented on FLINK-3292:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1551#discussion_r50993131
  
    --- Diff: 
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
 ---
    @@ -19,10 +19,7 @@
     package org.apache.flink.api.java.io.jdbc;
     
     import java.io.IOException;
    -import java.sql.Connection;
    -import java.sql.DriverManager;
    -import java.sql.SQLException;
    -import java.sql.Statement;
    +import java.sql.*;
    --- End diff --
    
    we don't allow star imports.


> Bug in flink-jdbc. Not all JDBC drivers supported
> -------------------------------------------------
>
>                 Key: FLINK-3292
>                 URL: https://issues.apache.org/jira/browse/FLINK-3292
>             Project: Flink
>          Issue Type: Bug
>          Components: other
>    Affects Versions: 1.0.0
>            Reporter: Subhobrata Dey
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> Hello,
> In method open in JDBCInputFormat.java, while using dbConn.createStatement, 
> the resultSetType & resultSetConcurrency are hardcoded. 
> These two fields may vary with different JDBC drivers & hence it fails in a 
> few cases like SAP HANA Jdbc driver. 
> There are two variants of the method dbCon.createStatement, one with 
> parameters & the other without  parameters. Both should be supported. 
> Thanks & regards,
> Subhobrata



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to