dawidwys commented on pull request #12056: URL: https://github.com/apache/flink/pull/12056#issuecomment-638714224
Sorry for a late reply. I will try to do a more thorough review once we are done with the 1.11 release testing. A few point from a brief look though: * we should not expose the concrete internal implementation of `RMQCollector` from `RMQSource`. It's better to have an interface defined in `RMQDeserializationSchema` * the correlation check will pass only for the first element of a correlationId from a batch. We should account for a situation when from a single RMQ record (single correlationId) we produce multiple flink records * In the end I think with @austince we discussed a slightly different `RMQCollector` interface: https://github.com/apache/flink/pull/12056#issuecomment-633982361 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
