SteNicholas opened a new pull request #12516:
URL: https://github.com/apache/flink/pull/12516


   ## What is the purpose of the change
   
   *Setting `jobmanager.memory.off-heap.size` to 0 results in this confusing 
error:`The configured or derived JVM heap memory size (jobstore.cache-size: 0 
bytes) is less than the configured or default size of the job store cache 
(jobmanager.memory.heap.size: 50.000mb (52428800 bytes))`.  This log is 
confused for users, and should modify the content of this warn log. Method 
`verifyJobStoreCacheSize` in `JobManagerFlinkMemoryUtils` should update 
validation result of jobstore cache size.*
   
   ## Brief change log
   
     - *Update warn log of method `verifyJobStoreCacheSize` in 
`JobManagerFlinkMemoryUtils`.*
   
   ## Verifying this change
   
     - *Add test method `testConfigJvmHeapAndOffHeapMemory` in 
`JobManagerProcessUtilsTest` to verfiy for JVM-Heap memory & Off-Heap memory 
configuration and the case that off-Heap memory is less than default jobstore 
cache size.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to