SteNicholas commented on a change in pull request #12516:
URL: https://github.com/apache/flink/pull/12516#discussion_r436528681
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerProcessUtilsTest.java
##########
@@ -69,6 +69,20 @@ public void testConfigOffHeapMemory() {
jobManagerProcessSpec ->
assertThat(jobManagerProcessSpec.getJvmDirectMemorySize(), is(offHeapMemory)));
}
+ @Test
+ public void testConfigJvmHeapAndOffHeapMemory() {
Review comment:
@azagrebin I previously want to add test for the case that the off-heap
size is less than jobstore cache size. I have removed this test method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
