twalthr commented on a change in pull request #12346:
URL: https://github.com/apache/flink/pull/12346#discussion_r436568215
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectStreamResult.java
##########
@@ -224,7 +224,7 @@ private void processDelete(Row row) {
}
for (int i = startSearchPos; i >= validRowPosition; i--) {
- if (materializedTable.get(i).equals(row)) {
+ if (materializedTable.get(i).fieldsEquals(row)) {
materializedTable.remove(i);
rowPositionCache.remove(row);
Review comment:
This field is valid in most locations. Just not for `Tuple2<Boolean,
Row>` generation, these path should be touched. Not the other non-legacy paths.
Where is `Tuple2<>` created, there is some MapFunction in the code base doing
this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
