twalthr commented on a change in pull request #12346:
URL: https://github.com/apache/flink/pull/12346#discussion_r436704980
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectStreamResult.java
##########
@@ -224,7 +224,7 @@ private void processDelete(Row row) {
}
for (int i = startSearchPos; i >= validRowPosition; i--) {
- if (materializedTable.get(i).equals(row)) {
+ if (materializedTable.get(i).fieldsEquals(row)) {
materializedTable.remove(i);
rowPositionCache.remove(row);
Review comment:
Sorry, maybe I was not specific enough. I didn't mean to remove the
field but I meant reseting the value of `RowKind`. All rows returned by
`Tuple2<Boolean, Row>` should have `Row.ofKind(RowKind.INSERT, ...)`. And users
should rely on the boolean flag instead. I hope this makes it clearer?
otherwise I can also assign this ticket to myself to speed things up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
