[
https://issues.apache.org/jira/browse/FLINK-17495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128223#comment-17128223
]
Chesnay Schepler commented on FLINK-17495:
------------------------------------------
This can be implemented more generically by configuring these for the entire
metric system and adding these labels as variables into the root metric groups.
This would then just work for all reporters.
> Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's
> groupingKey
> ----------------------------------------------------------------------------------------
>
> Key: FLINK-17495
> URL: https://issues.apache.org/jira/browse/FLINK-17495
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Metrics
> Reporter: jinhai
> Priority: Major
> Labels: pull-request-available
>
> We need to add some custom labels on Prometheus, so we can query by them.
> Now we can add jobName\groupingKey to PrometheusPushGatewayReporter in
> version 1.10, but not in PrometheusReporter.
> Can we add AbstractPrometheusReporter#addDimension method to support this, so
> they will be no differences except for the metrics exposing mechanism
> pulling/pushing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
