zhijiangW commented on a change in pull request #12513:
URL: https://github.com/apache/flink/pull/12513#discussion_r437277337
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
##########
@@ -1294,6 +1294,10 @@ static void submitTasksAndWaitForResults(ExecutorService
executor, Callable[] ta
for (Future result : results) {
result.get();
}
+
+ // wait until the internal channel state recover task finishes
+ executor.shutdown();
Review comment:
This util is widely used in many tests and every caller will also
shutdown it in finally region.
So it is better not shutdown it in this common place to avoid this executor
has some other usages afterwards.
We can verify the results in finally region after executor shutdown in this
specific unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
