zentol commented on a change in pull request #12533:
URL: https://github.com/apache/flink/pull/12533#discussion_r437540184
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/bash/BashJavaUtils.java
##########
@@ -92,9 +102,42 @@ public static void main(String[] args) throws
FlinkException {
JobManagerProcessSpec jobManagerProcessSpec =
JobManagerProcessUtils.processSpecFromConfigWithNewOptionToInterpretLegacyHeap(
configuration,
JobManagerOptions.JVM_HEAP_MEMORY);
+
+ logMasterConfiguration(jobManagerProcessSpec);
+
return
Collections.singletonList(ProcessMemoryUtils.generateJvmParametersStr(jobManagerProcessSpec));
}
+ private static void logMasterConfiguration(JobManagerProcessSpec spec) {
+ JobManagerFlinkMemory flinkMemory = spec.getFlinkMemory();
+ LOG.info("Final Master Memory configuration:");
+ LOG.info(" Total Process Memory: {}",
spec.getTotalProcessMemorySize().toHumanReadableString());
+ LOG.info(" Total Flink Memory: {}",
flinkMemory.getTotalFlinkMemorySize().toHumanReadableString());
+ LOG.info(" Heap: {}",
flinkMemory.getJvmHeapMemorySize().toHumanReadableString());
+ LOG.info(" Off-heap: {}",
flinkMemory.getJvmDirectMemorySize().toHumanReadableString());
+ LOG.info(" JVM Metaspace: {}",
spec.getJvmMetaspaceSize().toHumanReadableString());
+ LOG.info(" JVM Overhead: {}",
spec.getJvmOverheadSize().toHumanReadableString());
+ }
+
+ private static void
logTaskExecutorConfiguration(TaskExecutorProcessSpec spec) {
+ TaskExecutorFlinkMemory flinkMemory = spec.getFlinkMemory();
+ MemorySize totalOffHeapMemory =
flinkMemory.getManaged().add(flinkMemory.getJvmDirectMemorySize());
+ LOG.info("Final TaskExecutor Memory configuration:");
Review comment:
that may be a bit overkill imo; I went more for a concise version.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/bash/BashJavaUtils.java
##########
@@ -39,6 +45,7 @@
* Utility class for using java utilities in bash scripts.
*/
public class BashJavaUtils {
+ private static final Logger LOG =
LoggerFactory.getLogger(BashJavaUtils.class);
Review comment:
It works though? All logging output goes to stdout, and the
configuration things are split out based on a prefix. Everything else is
treated as logging output; see `flink-dist/src/main/flink-bin/bin/config.sh:537`
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/bash/BashJavaUtils.java
##########
@@ -39,6 +45,7 @@
* Utility class for using java utilities in bash scripts.
*/
public class BashJavaUtils {
+ private static final Logger LOG =
LoggerFactory.getLogger(BashJavaUtils.class);
Review comment:
It works though? All logging output goes to stdout, and the
configuration things are split out based on a prefix. Everything else is
treated as logging output; see
`flink-dist/src/main/flink-bin/bin/config.sh:extractLoggingOutputs()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
