azagrebin commented on a change in pull request #12533:
URL: https://github.com/apache/flink/pull/12533#discussion_r437533360



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/util/bash/BashJavaUtils.java
##########
@@ -92,9 +102,42 @@ public static void main(String[] args) throws 
FlinkException {
                JobManagerProcessSpec jobManagerProcessSpec = 
JobManagerProcessUtils.processSpecFromConfigWithNewOptionToInterpretLegacyHeap(
                        configuration,
                        JobManagerOptions.JVM_HEAP_MEMORY);
+
+               logMasterConfiguration(jobManagerProcessSpec);
+
                return 
Collections.singletonList(ProcessMemoryUtils.generateJvmParametersStr(jobManagerProcessSpec));
        }
 
+       private static void logMasterConfiguration(JobManagerProcessSpec spec) {
+               JobManagerFlinkMemory flinkMemory = spec.getFlinkMemory();
+               LOG.info("Final Master Memory configuration:");
+               LOG.info("  Total Process Memory: {}", 
spec.getTotalProcessMemorySize().toHumanReadableString());
+               LOG.info("    Total Flink Memory: {}", 
flinkMemory.getTotalFlinkMemorySize().toHumanReadableString());
+               LOG.info("      Heap:             {}", 
flinkMemory.getJvmHeapMemorySize().toHumanReadableString());
+               LOG.info("      Off-heap:         {}", 
flinkMemory.getJvmDirectMemorySize().toHumanReadableString());
+               LOG.info("    JVM Metaspace:      {}", 
spec.getJvmMetaspaceSize().toHumanReadableString());
+               LOG.info("    JVM Overhead:       {}", 
spec.getJvmOverheadSize().toHumanReadableString());
+       }
+
+       private static void 
logTaskExecutorConfiguration(TaskExecutorProcessSpec spec) {
+               TaskExecutorFlinkMemory flinkMemory = spec.getFlinkMemory();
+               MemorySize totalOffHeapMemory = 
flinkMemory.getManaged().add(flinkMemory.getJvmDirectMemorySize());
+               LOG.info("Final TaskExecutor Memory configuration:");
+               LOG.info("  Total Process Memory:      {}", 
spec.getTotalProcessMemorySize().toHumanReadableString());
+               LOG.info("    Total Flink Memory:      {}", 
flinkMemory.getTotalFlinkMemorySize().toHumanReadableString());
+               LOG.info("      Total Heap Memory:     {}", 
flinkMemory.getJvmHeapMemorySize().toHumanReadableString());

Review comment:
       ```suggestion
                LOG.info("      JVM Heap Memory:     {}", 
flinkMemory.getJvmHeapMemorySize().toHumanReadableString());
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to