wuchong commented on a change in pull request #12536:
URL: https://github.com/apache/flink/pull/12536#discussion_r438018340
##########
File path:
flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/options/HBaseWriteOptions.java
##########
@@ -100,19 +98,15 @@ public static Builder builder() {
*/
public static class Builder {
- // default is 2mb which is defined in hbase
private long bufferFlushMaxSizeInBytes =
ConnectionConfiguration.WRITE_BUFFER_SIZE_DEFAULT;
- private long bufferFlushMaxRows = -1;
- private long bufferFlushIntervalMillis = -1;
+ private long bufferFlushMaxRows = 0;
Review comment:
I have tried, but Duration and MemorySize ConfigOptions doesn't allow
negative values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
