qinjunjerry commented on a change in pull request #12589:
URL: https://github.com/apache/flink/pull/12589#discussion_r438218371
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -961,6 +971,10 @@ protected void
recoverAndCommit(FlinkKafkaProducer.KafkaTransactionState transac
"Presumably this transaction
has been already committed before",
ex,
transaction);
+ } finally {
+ if (producer != null) {
+ producer.close(30, TimeUnit.SECONDS);
Review comment:
@aljoscha We want to use close(3) instead of close(0) here, right? I
have to say I did not read all the code logic there. Same question for the one
below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
