aljoscha commented on a change in pull request #12589:
URL: https://github.com/apache/flink/pull/12589#discussion_r438582786



##########
File path: 
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -961,6 +971,10 @@ protected void 
recoverAndCommit(FlinkKafkaProducer.KafkaTransactionState transac
                                                "Presumably this transaction 
has been already committed before",
                                        ex,
                                        transaction);
+                       } finally {
+                               if (producer != null) {
+                                       producer.close(30, TimeUnit.SECONDS);

Review comment:
       Ah, something in the rebase must have gone wrong, initially there were 
two separate commits. Thanks for catching it!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to